Separation filtering and formatting#189
Open
night556 wants to merge 2 commits into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
=========================================
Coverage ? 86.02%
=========================================
Files ? 52
Lines ? 3113
Branches ? 0
=========================================
Hits ? 2678
Misses ? 304
Partials ? 131
Continue to review full report at Codecov.
|
wenzuochao
reviewed
Jun 28, 2019
| if table.IsEmptyCell() && table.IsEmptySub() { | ||
| table.ParentTable().Remove(table) | ||
| } | ||
| if table.ParentTable() != nil { |
Contributor
There was a problem hiding this comment.
当前表未删除的时候，不需要判断他的父表是否需要删除
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #189 +/- ##
==========================================
- Coverage 86.73% 86.02% -0.71%
==========================================
Files 50 52 +2
Lines 3060 3113 +53
==========================================
+ Hits 2654 2678 +24
- Misses 281 304 +23
- Partials 125 131 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.