fix: harden A2A recovery e2e flows#158
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Rollback recovery could restart the target step with only a generic continue/control message. In the rollback-step2 flow, Step1 no longer saw the changed user requirement and could complete with the wrong intent. Separately, terminal publication and cancellation races could leave A2A recovery state stale around active interrupts and backup-committed events.
Validation
make translateuv run pytest tests/pipeline/engine/test_pipeline_runner_interrupt.py::TestRollbackContextPropagation tests/pipeline/engine/test_pipeline_runner.py::test_step_rollback_forwards_reason_to_target_step -q→ 18 passeduv run ruff check src/iac_code/pipeline/engine/pipeline_runner.py tests/pipeline/engine/test_pipeline_runner_interrupt.pymake test→ 8620 passed, 1 skipped, 271 warningsmake lint→ ruff passed, ty passed/var/folders/mj/nr6v3rsj3qs6sb6g27lf9zr80000gn/T/iac-code-a2a-e2e-runs/post-fix-full-matrix-20260710T001540Zfault-after-snapshot: PASS at/var/folders/mj/nr6v3rsj3qs6sb6g27lf9zr80000gn/T/iac-code-a2a-e2e-runs/post-fix-fault-after-snapshot-20260710T022226Z