Allow passing an env var for the strict mode ignore comment#90
Open
Eric162 wants to merge 1 commit intoallegro:masterfrom
Open
Allow passing an env var for the strict mode ignore comment#90Eric162 wants to merge 1 commit intoallegro:masterfrom
Eric162 wants to merge 1 commit intoallegro:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the explanation to the readme:
You can customize the ignore comment used by the plugin through the
TS_STRICT_IGNORE_COMMENTenvironment variable. This is particularly useful for teams migrating to strict mode who want
different behavior between their development environment and CI pipeline.
Example:
in package.json scripts:
{ "scripts": { "typecheck": "tsc && TS_STRICT_IGNORE_COMMENT=@ts-strict-ci-ignore tsc-strict" } }@ts-strict-cli-ignorewill be ignored only by the CLI tool in CIbuild
Have this running in my company repo through patch-package and it is working great!