Fix LR schedulers when warmup/decay rounds to zero#655
Open
xsinxx wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary This PR makes LR schedulers robust to warmup=0 / decay=0 (and fraction-based warmup/decay that rounds to 0). Previously, these configurations could lead to division-by-zero in the linear warmup/decay helpers.
Changes
Treat warmup=0 as “no warmup” and avoid entering linear warmup when warmup == 0 :
Treat decay=0 as “no decay” and avoid entering linear decay when decay == 0 :
Handle WSDS period decay steps D == 0 by returning decay_min_lr directly to avoid division-by-zero.
Tests
Added unit tests covering:
Ran: python -m pytest -q src/test/optim/scheduler_test.py (all passed)
Behavioral Impact
No behavior change for configurations with warmup > 0 and decay > 0 .
Configurations with warmup=0 / decay=0 now behave as “disabled phase” instead of raising due to division-by-zero.