Fix fused_linear_cross_entropy_loss adding the z-loss term to the loss when compute_z_loss=False#702
Open
ReinforcedKnowledge wants to merge 1 commit into
Open
Conversation
…s when compute_z_loss=False
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
liger's
lse_square_scalefolds m * lse^2 into the returned loss whenever it's non-zero.return_z_lossonly controls the separate return. SinceLMHead.forwardpassesz_loss_multiplier or 1e-4, fused-loss runs with z-loss off return ce + 1e-4 * lse^2. Thecompute_z_loss=Truepath is unaffected.Try this with:
I tried it on a cluster on 1 A100: