Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances multiprocessing support by ensuring global variables are correctly initialized in worker processes, standardizing pool creation with the spawn context, and refactoring ternary and comprehension formatting. It also adds tests to verify consistency and fallback behavior when using multiple processes.
- Introduce
_init_poolhelpers and switch tomultiprocessing.get_context("spawn")in both featurizer and data modules - Refactor multiline ternary expressions and list comprehensions for readability
- Add comprehensive tests to confirm single‐ vs. multi‐process output consistency and fallback logic
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test_featurizer.py | New tests for featurization consistency, global dataset init, and fallbacks |
| tests/test_data.py | New tests for preprocessing consistency, global var init, and fallbacks |
| s2and/featurizer.py | Use spawn context, add _init_pool, refactor feature‐tuple formatting |
| s2and/data.py | Use spawn context, add _init_pool, refactor comprehension formatting |
Comments suppressed due to low confidence (1)
tests/test_data.py:230
- [nitpick] The test verifies key fields but omits other derived attributes (e.g.,
title_ngrams_chars,venue_ngrams); consider extending assertions to cover all preprocessing outputs for full consistency checks.
assert paper_single.title == paper_multi.title, f"Title mismatch for paper {paper_id}"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frees us from Python 3.8...