Support env var overrides and fix DummyViewer hang#117
Draft
jbragg wants to merge 3 commits into
Draft
Conversation
Allows SUBMISSION_DATASET, RESULTS_DATASET, LEADERBOARD_PATH, and CONTACT_DATASET to be set via environment variables for dev/testing purposes without modifying the code.
Add early return for DummyViewer in get_full_leaderboard_data to prevent transformation of error DataFrames which caused hanging. Add unit tests and update CI to run them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SUBMISSION_DATASET,RESULTS_DATASET,LEADERBOARD_PATH) to enable local development with custom HF datasetsDummyVieweris returned (error case) - now returns empty DataFrame immediately instead of trying to transform error dataget_full_leaderboard_datafunctionTest plan
Related to: allenai/astabench-issues#483