This repository was archived by the owner on Nov 4, 2025. It is now read-only.
Various executor and context representation fixes#22
Open
pdasigi wants to merge 6 commits into
Open
Conversation
pdasigi
force-pushed
the
executor_updates
branch
from
November 29, 2018 01:56
36dd03a to
8637a65
Compare
pdasigi
added a commit
to pdasigi/iterative-search-semparse
that referenced
this pull request
Nov 30, 2018
pdasigi
added a commit
to pdasigi/iterative-search-semparse
that referenced
this pull request
Nov 30, 2018
pdasigi
added a commit
to pdasigi/iterative-search-semparse
that referenced
this pull request
Nov 30, 2018
pdasigi
added a commit
to pdasigi/iterative-search-semparse
that referenced
this pull request
Nov 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After these fixes only 8% of the logical forms produced by Chen's random exploration code cannot be executed by our executor. The unexecutable ones are related to discrepancies in how we deal with some edge cases in the logic (e.g.: how should filtering operations deal with empty cells). The logical forms are mostly spurious, and I don't think we need to cover them.
There are also some other untranslatable logical forms for various reasons, and on the whole we can use logical forms for 95% of the questions.