Open
Conversation
| # Check if we're already on the target branch (e.g., main after shallow clone) | ||
| result = subprocess.run( | ||
| ["git", "rev-parse", "--abbrev-ref", "HEAD"], capture_output=True, text=True | ||
| ) |
There was a problem hiding this comment.
Bug: Missing error check on subprocess git command
The subprocess.run call for git rev-parse --abbrev-ref HEAD is missing check=True, unlike all other subprocess calls in this function. If this git command fails, the code continues silently with result.stdout potentially empty or containing unexpected output. The subsequent comparison current_branch == commit_branch could then incorrectly fall through to the else branch, masking the actual error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there were some bugs in launching a command of this pattern (custom oe eval branch, using gantry)
this change handles tracking of that git branch (and handles a sub-case if the custom branch specified is 'main')