Skip to content

Updates experiment script#1641

Merged
finbarrtimbers merged 5 commits intomainfrom
finbarr/update-script
Apr 27, 2026
Merged

Updates experiment script#1641
finbarrtimbers merged 5 commits intomainfrom
finbarr/update-script

Conversation

@finbarrtimbers
Copy link
Copy Markdown
Collaborator

No description provided.

@finbarrtimbers finbarrtimbers requested a review from mnoukhov April 27, 2026 17:52
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the qwen3_4b_dapo_math.sh script to allow the Beaker image to be set via a positional argument, modifies default cluster and priority settings, and updates evaluation datasets to the allenai namespace. A significant issue was identified in the logic for parsing the Beaker image argument, as it could incorrectly consume command-line flags intended for the training script.

Comment thread scripts/train/qwen/qwen3_4b_dapo_math.sh Outdated
@finbarrtimbers
Copy link
Copy Markdown
Collaborator Author

Switched to passing BEAKER_IMAGE via env var from build_image_and_launch.sh per @mnoukhov's suggestion. The qwen script now just reads ${BEAKER_IMAGE:-nathanl/open_instruct_auto} with no positional consumption, so flags like --learning_rate pass through cleanly.

Comment thread scripts/train/build_image_and_launch.sh Outdated
… is already exported. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…existing positional-arg pattern. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@mnoukhov mnoukhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's do the BEAKER_IMAGE change in a future PR

@finbarrtimbers finbarrtimbers added this pull request to the merge queue Apr 27, 2026
Merged via the queue into main with commit 5e93387 Apr 27, 2026
7 checks passed
@finbarrtimbers finbarrtimbers deleted the finbarr/update-script branch April 27, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants