Fix submit_eval_jobs.py for olmo-eval-internal runs#1644
Open
finbarrtimbers wants to merge 8 commits intomainfrom
Open
Fix submit_eval_jobs.py for olmo-eval-internal runs#1644finbarrtimbers wants to merge 8 commits intomainfrom
finbarrtimbers wants to merge 8 commits intomainfrom
Conversation
…aude Opus 4.7 <noreply@anthropic.com>
…ply@anthropic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates scripts/submit_eval_jobs.py to resolve environment issues by removing a problematic vllm upgrade, pinning numpy<2.3 for compatibility, and correcting the max_tokens override path. Review feedback identified a placeholder REPLACE_ME in the CHANGELOG.md entry that needs to be updated with the correct pull request number before merging.
…l.sh. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…f to SHA at submit time; collapse install script's pip calls. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…stall script header comments. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…ler always provides a ref. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…dia; tag spec description with git branch+commit. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three fixes to
scripts/submit_eval_jobs.pyso the script can submit working olmo-eval-internal jobs:vllm[runai]>=0.19.0upgrade: it was pulling cu13 wheels on top of the image's cu12.8 install, breaking the CUDA driver match (CUDA driver too old, version 12080 found). The image's bundled vLLM is sufficient.numpy<2.3alongside thetransformers>=5.4.0upgrade: transformers 5.4 pulls NumPy 2.4, which is incompatible with numba (Numba needs NumPy 2.2 or less). The transformers upgrade is needed for newer-model tokenizer support.--sampling_max_tokensoverride path: was emitting-o max_tokens=N(rejected asnot a TaskConfig field). Now emits-o sampling_params.max_tokens=Nto match the nested field.How to re-run the validation eval
Runs:
Test plan
sampling_params.max_tokensoverride is accepted by the CLI.GPU_TESTS=bypass
🤖 Generated with Claude Code