Fix Blurry issue by forcing rebuild ObjectUrl in PageRenderContext#181
Draft
huytr1995 wants to merge 1 commit into
Draft
Fix Blurry issue by forcing rebuild ObjectUrl in PageRenderContext#181huytr1995 wants to merge 1 commit into
huytr1995 wants to merge 1 commit into
Conversation
pauls-ai2
reviewed
Aug 25, 2022
pauls-ai2
left a comment
pauls-ai2
left a comment
Contributor
There was a problem hiding this comment.
This seems like the wrong direction. isScaleChanged is effectively scale !== DEFAULT_SCALE, except it never goes back.
pauls-ai2
reviewed
Aug 25, 2022
| const viewport = pageProxy.getViewport({ scale: scale * zoomMultiplier * devicePixelRatio }); | ||
| canvas.height = viewport.height; | ||
| canvas.width = viewport.width; | ||
| canvas.style.width = '100%'; //de-zoom canvas with style (maybe you can directly use CSS), reaching de-zoom of higher definition PDF |
Contributor
There was a problem hiding this comment.
Style is meaningless when the element isn't in the DOM.
Contributor
There was a problem hiding this comment.
You might try canvasContext.imageSmoothingEnabled = false;.
Another thing you could try is canvasContext.imageSmoothingQuality = 'high';.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the change and its purpose. Include a ticket if applicable.
Reviewer Instructions
Anything a review needs to know about this PR to help them give better feedback. Are there specific questions you have? Are there areas you are unsure of? Does this come from or relate to another part of the codebase?
Testing Plan
Describe what you did to test the change.
Output / Screenshots
Before
What did it look like before?
After
What will it look like after merging?
A11y
How do keyboard navigation and screen readers work with this PR?