Skip to content

Fix Page numbers don't update when navigating with thumbnails #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huytr1995 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix Page numbers don't update when navigating with thumbnails #202

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba39808
Increasing threshold for IntersectionObserver
huytr1995 Oct 11, 2022
81b72c1
Minor change
huytr1995 Oct 11, 2022
c473068
Another minor change
huytr1995 Oct 11, 2022
a8fd254
Final change
huytr1995 Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ui/library/src/utils/VisibleEntriesDetector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
const DEFAULT_ROOT_MARGIN = '50px';
// This array is a range from 0.0001 to 1 range of threshold. It will help with detecting
// on scroll with a better % compare to a fix threshold but not firing too frequent that
// can hamper our performance.
const DEFAULT_THRESHOLD = [0.0001, 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 0.99];
const DEFAULT_THRESHOLD = 0;

export type SetVisibleEntriesCallback<TEntry> = (visible: Map<TEntry, number>) => void;
export type onVisibleEntriesChangeCallback<TEntry> = (args: {
Expand Down