[Enhancement] Add documentation and tests for ERA5 temporal stack materialization#629
[Enhancement] Add documentation and tests for ERA5 temporal stack materialization#629robmarkcole wants to merge 2 commits intomasterfrom
Conversation
favyen2
left a comment
There was a problem hiding this comment.
Looks good to me, I think it is useful to document alternative recommended compositing methods and such with the data source. One suggestion would be to reduce duplication by just saying to change the SPATIAL_MOSAIC_TEMPORAL_STACK to one of those other ones instead of having the whole config again, this way it is less to read for the user (especially if more sections are added in the future, it can be hard to navigate through the document if there is a lot of redundancy). Anyway you can decide whether to change that and then merge.
|
BTW @Farbum said that the numpy raster format is much faster with many bands. Do you have the same experience, where GeotiffRasterFormat should put all the timesteps into a single GeoTIFF file, but it still ends up being much slower than the numpy file due to ending up with so many dimensions on the band axis? If the GeoTIFF works okay then it could make sense to stick with that instead of overriding the raster format. |
Address #587
Validation: EarthDataHub ERA5 unit tests passed locally.