Skip to content

[Enhancement] Add documentation and tests for ERA5 temporal stack materialization#629

Open
robmarkcole wants to merge 2 commits intomasterfrom
issue-587
Open

[Enhancement] Add documentation and tests for ERA5 temporal stack materialization#629
robmarkcole wants to merge 2 commits intomasterfrom
issue-587

Conversation

@robmarkcole
Copy link
Copy Markdown
Collaborator

Address #587

  • Documented the recommended ERA5 daily time-series path using SINGLE_COMPOSITE, SPATIAL_MOSAIC_TEMPORAL_STACK, and NumpyRasterFormat.
  • Added guidance for temporal aggregation via TEMPORAL_MEAN, TEMPORAL_MAX, and TEMPORAL_MIN.
  • Added tests covering ERA5 materialization to one CTHW NumPy raster, including clipped temporal stacks and reducer outputs.

Validation: EarthDataHub ERA5 unit tests passed locally.

@robmarkcole robmarkcole changed the title Add documentation and tests for ERA5 temporal stack materialization [Enhancement] Add documentation and tests for ERA5 temporal stack materialization Apr 29, 2026
Copy link
Copy Markdown
Collaborator

@favyen2 favyen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I think it is useful to document alternative recommended compositing methods and such with the data source. One suggestion would be to reduce duplication by just saying to change the SPATIAL_MOSAIC_TEMPORAL_STACK to one of those other ones instead of having the whole config again, this way it is less to read for the user (especially if more sections are added in the future, it can be hard to navigate through the document if there is a lot of redundancy). Anyway you can decide whether to change that and then merge.

@favyen2
Copy link
Copy Markdown
Collaborator

favyen2 commented Apr 30, 2026

BTW @Farbum said that the numpy raster format is much faster with many bands. Do you have the same experience, where GeotiffRasterFormat should put all the timesteps into a single GeoTIFF file, but it still ends up being much slower than the numpy file due to ending up with so many dimensions on the band axis?

If the GeoTIFF works okay then it could make sense to stick with that instead of overriding the raster format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants