Henryh/yemen crop #270
Open
Henryh/yemen crop #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favyen2
reviewed
Jan 20, 2026
| def init_mp() -> None: | ||
| """Set start method to preload and configure forkserver preload.""" | ||
| multiprocessing.set_start_method("forkserver", force=True) | ||
| multiprocessing.set_forkserver_preload( |
Collaborator
There was a problem hiding this comment.
Can we keep the preload, in case ? It makes it much faster if forkserver is used.
favyen2
reviewed
Jan 20, 2026
| def init_mp(context: str | None = None, sharing_strategy: str | None = None) -> None: | ||
| """Set start method for multiprocessing. | ||
|
|
||
| Uses RSLEARN_MULTIPROCESSING_CONTEXT if provided, else defaults to forkserver. |
Collaborator
There was a problem hiding this comment.
I think this could be clarified a bit. Also context does not seem like the correct name, should it be mp_start_method instead? Something like:
Args:
mp_start_method: the multiprocessing start method to set. If not set, use the RSLEARN_MULTIPROCESSING_CONTEXT if provided. Otherwise, it defaults to forkserver.
sharing_strategy: the torch sharing strategy to set. If not set, use the MP_SHARING_STRATEGY_ENV_VAR if provided. Otherwise, the sharing strategy is not changed.
favyen2
reviewed
Jan 20, 2026
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| multiprocessing.set_start_method("forkserver") |
Collaborator
There was a problem hiding this comment.
init_mp should be called here since we only call it in the entrypoints, not in the main functions. Moving init_mp into the main function in rslearn_main.py could be okay too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.