Add ability to display the executor output#491
Open
BigRedT wants to merge 3 commits intoallenai:mainfrom
Open
Conversation
Add ability to display the executor output. Can be used as follows: ```python output = executor.execute_step_graph(step_graph) output.display() ```
epwalsh
reviewed
Dec 9, 2022
Contributor
epwalsh
left a comment
There was a problem hiding this comment.
This looks great. I think the CI failures are all minor. Try running black . and isort . to fix formatting. Then run flake8 . and mypy . to see what they're complaining about
Contributor
Author
|
@epwalsh fixed the formatting issues. Not sure if the remaining 3 failing checks are related to this PR? |
epwalsh
reviewed
Dec 16, 2022
Contributor
epwalsh
left a comment
There was a problem hiding this comment.
Can you replace the old code in tango/__main__.py to just calling this new method? Don't worry about the remaining failing tests in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #487
Changes proposed in this pull request:
Lightly modified version of code pointed by @epwalsh here
Adds the ability to display the executor output. Can be used as follows:
Tested locally and produces an output as follows:
Before submitting
section of the
CONTRIBUTINGdocs.Writing docstrings section of the
CONTRIBUTINGdocs.After submitting