Issue-71: Fix type mismatch for condition in am_enqueue_script - #72
Merged
mslinnea merged 3 commits intoJul 14, 2025
Merged
Conversation
mslinnea
marked this pull request as ready for review
July 11, 2025 21:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #71
Description
This pull request resolves a PHPStan type mismatch error related to the
conditionparameter in theam_enqueue_scriptfunction. Previously, the PHPStan annotation for the$handleparameter incorrectly restricted theconditionkey to astring, even though the implementation and PHPDoc allowed botharrayandstringtypes. This update modifies the@phpstan-paramannotation insrc/helpers.phpto acceptarray<string, mixed>|stringfor$handleand updates the expected types for related parameters. Now, theconditionkey is correctly recognized by static analysis tools as supporting both arrays and strings, eliminating false-positive errors from PHPStan.Testing Instructions
am_enqueue_script, passing$handleas an array with aconditionkey set to an array.condition.Additional Context
See the original issue for more details: #71
Checklist