SCRUM-4817 put Model entities into ES #1311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devopsagr
reviewed
Apr 25, 2025
| @@ -95,7 +95,7 @@ public void progressProcess(String data, long amount) { | |||
|
|
|||
| double percent = 0; | |||
| if (totalSize > 0) { | |||
| percent = sizeCounter.get() / totalSize; | |||
| percent = ((double) sizeCounter.get() / (double) totalSize); | |||
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.UnnecessaryParenthesesCheck> reported by reviewdog 🐶
Unnecessary parentheses around assignment right-hand side.
oblodgett
reviewed
Apr 25, 2025
| @DefaultValue("0") @QueryParam("page") Integer page, | ||
| @DefaultValue("10") @QueryParam("limit") Integer limit, | ||
| HashMap<String, Object> params); | ||
| } |
There was a problem hiding this comment.
This needs to be removed and we use the one in curation.
oblodgett
reviewed
Apr 25, 2025
| public SearchResponse<AffectedGenomicModelDocument> getModelDocument(String modelId) { | ||
| HashMap<String, Object> params = new HashMap<>(); | ||
| params.put("primaryExternalId", modelId); | ||
| return modelApi.findForPublic(0, 1, params); |
There was a problem hiding this comment.
Should we we pulling these in batches from curation. As one at time I would think is going to be slow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.