Filter empty entries out of the SDK list - #286
Open
makadore wants to merge 1 commit into
Open
Conversation
--sdks= splits into a list holding one empty string rather than an empty list, and that empty string is then looked up as an SDK name, so configure fails with an empty name in both messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--sdks=splits into a list holding one empty string rather than an empty list, and that empty string is then looked up as an SDK name. It never matches anything, so configure fails withError: hl2sdk- was not found.andMissing hl2sdks:— both without a name, which makes the cause hard to see.The
pr-checksworkflow passes--sdks=for the two SourceHook test builds, so those steps cannot configure at all on this branch.masteralready filters empty entries here; this is the same line.Checked on a clean
1.12-devcheckout: before,python3 ../configure.py --enable-optimize --enable-tests --sdks=fails as above; after, it configures, builds, and the SourceHook suite passes 16 of 16 on linux-x86.Ordinary builds are unaffected —
--sdks=hl2dmproduces the same artifacts before and after, and the only differences between the two binaries are the build path and the compile timestamp, which also differ between two runs of the unmodified code.