Fix TF2_OnConditionAdded/Removed breaking after player gains TF_COND_CRITBOOSTED - #2357
Merged
Conversation
Kenzzer
approved these changes
Sep 26, 2025
cafeed28
pushed a commit
to cafeed28/sourcemod
that referenced
this pull request
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When detecting cond changes to call
TF2_OnConditionAdded/TF2_OnConditionRemoved, the values of them_nPlayerCondand_condition_bitsnetprops are merged together when either of them change (_condition_bitsis a special legacy netprop that only handles cond 11TF_COND_CRITBOOSTED). This behavior is not implemented correctly and can break the tracking of some conditions for a client if they gainTF_COND_CRITBOOSTEDdue to the way the merged value is saved tom_OldConds.I don't believe this special handling is actually necessary at all.
_condition_bitsis only used for cond 11, and bit 11 is never set onm_nPlayerCond, so keeping the two props completely separate seems to work fine.Fixes #840