Skip to content

Fix issues with -fPIC thunks - #2366

Merged
Kenzzer merged 4 commits into
masterfrom
k/fpic_fix
Oct 26, 2025
Merged

Fix issues with -fPIC thunks#2366
Kenzzer merged 4 commits into
masterfrom
k/fpic_fix

Conversation

@Kenzzer

@Kenzzer Kenzzer commented Oct 21, 2025

Copy link
Copy Markdown
Member

Close #2212
Close #2343

Relevant : alliedmodders/safetyhook#8

Thanks to @etkaar for testing this!

@Kenzzer

Kenzzer commented Oct 21, 2025

Copy link
Copy Markdown
Member Author

@A1mDev been told you opened an issue for this cursey/safetyhook#90 this should interest you as well

@A1mDev

A1mDev commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Are you planning to make a PR in the official repo?

@Kenzzer

Kenzzer commented Oct 21, 2025

Copy link
Copy Markdown
Member Author

If I can confirm there are no breakages from this, yes absolutely

@etkaar

etkaar commented Oct 21, 2025

Copy link
Copy Markdown

Thanks for your effort!

@Kenzzer Kenzzer changed the title Update safetyhook submodule Fix issues with -fPIC thunks Oct 21, 2025
@Kenzzer
Kenzzer merged commit 42c5444 into master Oct 26, 2025
4 checks passed
@Kenzzer
Kenzzer deleted the k/fpic_fix branch October 26, 2025 16:33
@A1mDev

A1mDev commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

Can this commit be added to SourceMod 1.12?
The latest 1.12 version is still broken and causes crashes with some extensions, even though it’s officially considered stable. This forces developers to spend unnecessary time searching for a solution, even though the issue has already been fixed.

@psychonic

Copy link
Copy Markdown
Member

Can this commit be added to SourceMod 1.12? The latest 1.12 version is still broken and causes crashes with some extensions, even though it’s officially considered stable. This forces developers to spend unnecessary time searching for a solution, even though the issue has already been fixed.

Yes, after it bakes in 1.13 a little bit longer

@Alienmario

Copy link
Copy Markdown
Contributor

I can confirm my original issue is resolved, Thanks!

psychonic pushed a commit that referenced this pull request Nov 25, 2025
cafeed28 pushed a commit to cafeed28/sourcemod that referenced this pull request Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: CS_OnCSWeaponDrop with Plugin_Continue causes crash on servers within private networks Regression in detour after Dhooks safetyhook

5 participants