Enhance Spinner Component with Loading Text and Customization Options#2
Open
ruimarcosjoao wants to merge 7 commits into
Open
Enhance Spinner Component with Loading Text and Customization Options#2ruimarcosjoao wants to merge 7 commits into
ruimarcosjoao wants to merge 7 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, I have made significant enhancements to the Spinner component to improve its functionality and flexibility.
The key changes include:
Addition of defaultText: I introduced a new prop, defaultText, which allows the spinner to display a message while loading. This provides better feedback to users about ongoing processes.
Support for Default Text and Children: The component now supports displaying default text and custom children when not in a loading state. This allows for more personalized usage of the spinner in various contexts.
Improved Logic for Loading States: I refactored the component's logic to handle different loading states more clearly, ensuring a consistent and predictable behavior.
These improvements aim to enhance the user experience by providing clear visual feedback during loading operations and allowing for greater customization of the spinner's appearance and behavior.
I believe these updates will make the Spinner component more versatile and user-friendly. Thank you for considering this pull request!