Skip to content

feat(ws): retry mechanism in WsConnect #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

feat(ws): retry mechanism in WsConnect #2303

merged 2 commits into from
Apr 10, 2025

Conversation

yash-atreya
Copy link
Member

Motivation

Closes #2252

Solution

  • Adds max_retries and retry_interval param to WsConnect
  • These are propagated to the PubsubService handling retries via the ConnectionHandle
  • Default max_retries: 10 and retry_interval: 3s

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@yash-atreya yash-atreya marked this pull request as ready for review April 10, 2025 10:32
This was referenced Apr 10, 2025
Merged
Open
mattsse
mattsse approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this is better than what I had in mind.

this should be flexible enough

@github-project-automation github-project-automation bot moved this to Reviewed in Alloy Apr 10, 2025
@yash-atreya yash-atreya merged commit 167caf5 into main Apr 10, 2025
27 checks passed
@yash-atreya yash-atreya deleted the yash/ws-reconnect branch April 10, 2025 15:01
@github-project-automation github-project-automation bot moved this from Reviewed to Done in Alloy Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Alloy
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] No custom policy and no retry is done for disconnected web socket
2 participants
@yash-atreya @mattsse