fix!: check each bloom #2480
Merged
fix!: check each bloom #2480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Federico Gimenez <[email protected]>
jgomez360
pushed a commit
to jgomez360/alloy
that referenced
this pull request
Jun 15, 2025
* fix: check each bloom * fix: check each bloom * fix: check each bloom * Update crates/rpc-types-eth/src/filter.rs Co-authored-by: Federico Gimenez <[email protected]> --------- Co-authored-by: Federico Gimenez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this would be an expensive workaroundinstead of a lazy single bloom, this computes the original BloomFilter again, that was incorrectly changed in #2140 and stores that in a oncelock instead of the single bloom
ref paradigmxyz/reth#16354