fix(sol-macro): derive Default for dynamic arrays of non-Default elements#1129
Open
satyakwok wants to merge 1 commit into
Open
fix(sol-macro): derive Default for dynamic arrays of non-Default elements#1129satyakwok wants to merge 1 commit into
satyakwok wants to merge 1 commit into
Conversation
…ents A dynamic Solidity array maps to Vec<T>, whose Default impl holds for any T. can_derive_default still required the element type to be Default for dynamic arrays, so a struct/error with a field like MyEnum[] lost its Default derive under #[sol(all_derives)] even though Vec<MyEnum>: Default. Only require the element to be Default (and length <= 32) for fixed-size arrays ([T; N]); dynamic arrays are always Default.
satyakwok
force-pushed
the
fix/default-dynamic-array-non-default-elem
branch
from
afa7bd4 to
066b214
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dynamic Solidity array maps to
Vec<T>, whoseDefaultimpl holds for anyT.can_derive_defaultstill required the element type to beDefaultfor dynamic arrays, so a struct/error with a field likeMyEnum[]lost itsDefaultderive under#[sol(all_derives)]even thoughVec<MyEnum>: Default.This mirrors how the field's Rust type is generated (
expand_rust_type_to):Some(size)→[T; N],None→Vec<T>. Only fixed-size arrays needT: Default(andN <= 32); dynamic arrays are alwaysDefault.Added a regression test (
test_default_dynamic_array_of_non_default_elem).