Serialize Signed Ints with a compact binary representation #953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ints are currently always serialized as strings, even for binary formats. This causes quite a bit of overhead depending on the downstream usage. (For example persisting to disk)
I256::MAX with the existing serialization format uses ~85 bytes with bincode, v.s. 40 bytes with this change
Solution
Use is_human_readable to serialize Ints as compact binary blobs instead.
PR Checklist
Considerations
This change isn't backwards compatible with already serialized data that has been f.x. persisted to disk with a non human readable format. Keeping the deserialize_any in the deserialize should technically work, but apparently some of the self describing formats just treat strings and bytes interchangeably, which means those will face compatibility issues anyway.
Making this change has the additional benefit of now allowing f.x. bincode to work with ints (because it gets rid of the deserialize_any in the non readable path).
Json and related readable formats (which I assume is the majority of downstream usage) shouldn't be impacted.