Skip to content

Conversation

@figtracer
Copy link

partially solves #46, may need to add more helpers in the future

@Soubhik-10
Copy link
Contributor

Flagging as breaking, as merging this might cause a few problems, will patch and see after Devconnect cc @Rimeeeeee

@mattsse
Copy link
Member

mattsse commented Nov 21, 2025

you're in charge here @Soubhik-10 🫡

@figtracer
Copy link
Author

thanks for the feedback! i'm happy to learn what needs adjustments

@figtracer figtracer marked this pull request as draft November 24, 2025 16:15
@figtracer figtracer marked this pull request as ready for review December 1, 2025 16:01
@figtracer
Copy link
Author

added some small patches, requesting for review again

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol suggestion

pending @Soubhik-10

@github-project-automation github-project-automation bot moved this to In Progress in Alloy Dec 6, 2025
@Soubhik-10
Copy link
Contributor

smol suggestion

pending @Soubhik-10

We need to patch this and see if something breaks or not before merging
Wdyt @Rimeeeeee

@figtracer
Copy link
Author

i finally found the bal branch you're working at 💯

we gotta implement Compact for BlockAccessList too reth/crates/storage/codecs/src/alloy/block_access_list.rs

error[E0599]: the function or associated item `from_compact` exists for struct `BlockAccessList`, but its trait bounds were not satisfied
   --> crates/storage/db-models/src/blocks.rs:156:45
    |
156 |             let (b, buf) = BlockAccessList::from_compact(buf, buf.len());
    |                                             ^^^^^^^^^^^^ function or associated item cannot be called on `BlockAccessList` due to unsatisfied trait bounds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants