-
Notifications
You must be signed in to change notification settings - Fork 16
feat(eip7928): make BAL a dedicated type #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Flagging as breaking, as merging this might cause a few problems, will patch and see after Devconnect cc @Rimeeeeee |
|
you're in charge here @Soubhik-10 🫡 |
|
thanks for the feedback! i'm happy to learn what needs adjustments |
|
added some small patches, requesting for review again |
mattsse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smol suggestion
pending @Soubhik-10
We need to patch this and see if something breaks or not before merging |
|
i finally found the bal branch you're working at 💯 we gotta implement |
partially solves #46, may need to add more helpers in the future