Support execute_block_with_transaction_closure #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a method `execute_block_with_transaction_closure` in `BlockExecutor` that lets callers process transactions. This returns the result of `finish` for persistence. Callers may use this to collect metrics for each transaction.
mattsse
requested changes
Nov 24, 2025
Comment on lines
+327
to
+328
| transactions: impl IntoIterator<Item = Tx>, | ||
| mut f: F, |
Member
There was a problem hiding this comment.
looking at the reth pr, then what would be more useful here if this accepts an iterator of results, then we can avoid the collect
Member
There was a problem hiding this comment.
yeah, it's actually quite important because doing collect on the iterator in reth is pretty expensive, because that iterator is yielding transactions that are decoded in parallel
klkvr
reviewed
Nov 24, 2025
Member
klkvr
left a comment
klkvr
left a comment
There was a problem hiding this comment.
not sure if this makes sense to me yet, the code on reth side didn't really become much simpler
it's not very complex to manually iterate through transactions and execute_block helper wasn't designed as a primary API so I'm not sure if we should try to make it such
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, Reth executes metered blocks with an in-lined implementation of
execute_block.This defies expectations that the
BlockExecutorowns its execution.Solution
Create a method
execute_block_with_transaction_closureinBlockExecutor.Callers—for instance—may wrap
execute_transactionin a trace.This clarifies ownership divides.
Reth PR.