Conversation
…l issues - MarkdownPreview: use dedicated CSS class without flex height constraints so the dynamically-measured iframe height attribute is respected (#679) - MarkdownPreview: drop height="100%" fallback before content loads; browser default height is more sensible in a block container - Modal: change overflow: hidden → overflow-y: auto on modal-data-component so tall markdown content can be scrolled within the modal (#679) - Modal: wire .attachmentViewStack/.attachmentViewPane into the flex height chain so HtmlPreview fills the fullscreen modal instead of collapsing to the browser default ~150px (#692) - HtmlPreview: set blob MIME to text/html; charset=utf-8 to prevent the iframe from guessing encoding from stale meta tags (#692) - TrAttachment: pass current preview state when opening the modal so HTML attachments open in preview mode, not source-code mode (#692)
- Always open modal in preview mode for previewable attachments (HTML/md),
regardless of current inline toggle state
- Fix markdown syntax highlighting: prism-markup must be imported before
prism-markdown since the latter calls Prism.languages.extend('markup')
- Add vertical padding to markdown-attachment-preview (was 0 top/bottom)
- Fix modal layout chain: make attachmentViewPane a flex column so
html-attachment-preview fills the fullscreen modal correctly
- Reset html/body margin in markdown iframe so scrollHeight is accurate
and preview does not scroll past visible content
- Fix expand button opening in source code: the actual expand icon lives in TrAttachmentInfo, not TrAttachment — pass preview: isPreviewable and previewable: isPreviewable there (and in the item-change effect) - Fix markdown preview scrolling past content: vertical padding on the container div caused the iframe (sized to content height) to overflow the container, making the last 16px scrollable past actual content. Move vertical padding inside the iframe body so getIframeContentHeight includes it in the measurement and container overflow is eliminated.
- Fix background cutoff below white card in BaseLayout - Fix inner corner rounding when no test is selected in split mode - Move focus stripe (border-top) to non-scrolling side-left/side-right containers so it stays visible on scroll; change to 2px - Fix keyboard navigation (p/arrows) not scrolling focused tree node into view: replace native scrollIntoView with scrollFocusIntoView for all node kinds - Account for sticky filter header height when pinning group/env nodes below it; use absolute content position to avoid negative scrollTop clamping - Fix webpack warning: import isSubtreeFirstLevelOnlyOpened directly from @allurereport/web-commons in TrSteps/index.tsx - Add scrollFocusIntoView tests covering group/env pin-to-top, sticky inset, leaf centering, and fallback behavior
Allure perf metricsGenerated at:
Artifacts: allure-perf-metrics |
formaceft-93
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
side-left/side-rightcontainers so it stays visible on scroll; change to 2pxp/arrows) not scrolling focused tree node into view: replace nativescrollIntoViewwithscrollFocusIntoViewfor all node kindsdata-tree-sticky-header) when pinning group/env nodes; use absolute content position to avoid negative scrollTop clamping issueisSubtreeFirstLevelOnlyOpeneddirectly from@allurereport/web-commonsinTrSteps/index.tsxscrollFocusIntoViewunit tests covering group/env pin-to-top, sticky inset, leaf centering, and native fallback