Skip to content
This repository was archived by the owner on Apr 11, 2024. It is now read-only.

Revamp build system & types#3

Merged
olance merged 14 commits intomasterfrom
build/microbundle
Nov 30, 2020
Merged

Revamp build system & types#3
olance merged 14 commits intomasterfrom
build/microbundle

Conversation

@olance
Copy link
Contributor

@olance olance commented Nov 28, 2020

Switch build system to using microbundle & properly configure tooling such as commitizen, semantic-release, ...

👉   Dependencies are up-to-date
👉   Uses a custom version of microbundle to allow configuring extra rollup plugins: developit/microbundle#755
👉   Massively reworks the internal types to have everything compile without any TS error (that was not the case before)
They still aren't perfect, but already much better. Runtime errors might still be possible in some cases

  • I'm gonna add a few tests on some critical functions before merging

- Microbundle with UMD, CJS & ESM builds
- CI/CD powered by semantic-release
- Test setup with Jest
- Prettier & eslint setup
…rrors

They still aren't perfect, but already much better.
Runtime errors are potentially still possible
in some cases
@olance olance requested a review from Taskim November 28, 2020 12:44
@olance olance marked this pull request as draft November 28, 2020 12:49
@olance olance marked this pull request as ready for review November 28, 2020 22:03
@olance
Copy link
Contributor Author

olance commented Nov 28, 2020

Only wrote one test for makeConfig, which underpins, on the runtime side, the whole new settings/config types of this PR

Other tests will follow, they're just not within the scope of this PR :)

@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@97b05d8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   16.46%           
=========================================
  Files             ?       11           
  Lines             ?      577           
  Branches          ?      101           
=========================================
  Hits              ?       95           
  Misses            ?      453           
  Partials          ?       29           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97b05d8...de8a80a. Read the comment docs.

@olance olance requested a review from Taskim November 30, 2020 19:07
@olance
Copy link
Contributor Author

olance commented Nov 30, 2020

@Taskim Voilà ! Code coverage is up :)

@olance olance merged commit 159561d into master Nov 30, 2020
@olance olance deleted the build/microbundle branch November 30, 2020 19:11
@olance
Copy link
Contributor Author

olance commented Dec 9, 2020

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@olance olance added the released label Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants