This repository was archived by the owner on Oct 19, 2024. It is now read-only.
Use shell script to drive jaxlib build - #909
Open
yhtang wants to merge 1 commit into
Open
Conversation
yhtang
changed the title
gjoliver
reviewed
Mar 31, 2023
gjoliver
left a comment
gjoliver
left a comment
Member
There was a problem hiding this comment.
nice cleanup.
let's figure out when we should merge this.
|
|
||
| if [[ "${EDITABLE}" == "1" ]]; then | ||
| BUILD_PARAM="${BUILD_PARAM} --editable" | ||
| fi |
Member
There was a problem hiding this comment.
why don't we do this directly in the flag parsing while loop above?
you then don't need the additional EDITABLE variable.
|
|
||
| if [[ "$DEBUG" == "1" ]]; then | ||
| BUILD_PARAM="${BUILD_PARAM} --bazel_options=-c --bazel_options=dbg --bazel_options=--strip=never --bazel_options=--cxxopt=-g --bazel_options=--cxxopt=-O0" | ||
| fi |
| print_var TF_NCCL_VERSION | ||
| print_var CC_OPT_FLAGS | ||
|
|
||
| print_var BUILD_PARAM |
Member
There was a problem hiding this comment.
BUILD_PARAM is printed twice. get rid of the one above I guess?
| @@ -0,0 +1,30 @@ | |||
| //usr/bin/env nvcc -odir `mktemp -d` -x cu --run "$0" ${1:+--run-args "${@:1}"} ; exit $? | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Together with jax-ml/jax#15205, this should eliminate the need to apply the
build_jaxlib/update_build_scripts.patcheach time we rebase. Note the--editableoption will only be usable once alpa is rebased onto JAX 0.4.8.The original
update_build_scripts.patchfile is meant to provide two functionalities: