CI: refactor and extend atomic tests #1772

psychocoderHPC · 2022-08-03T12:49:07Z

merge after fix atomicDec() for CPU #2582 (first commit contains the fix for atomicDec)

clang CUDA is exposing atomic*_block() function signatures even if these can not be used by the selected architecture.
This leads to compile issues if clang is used as CUDA compiler.

Our tests cases have not checked all combinations of atomics, therefore the second commit refactors the atomic tests and fixes #1769:

test all hierarchies which can be used for atomics
extent test cases to test for equal, smaller, larger, and zero as left side operand
test calling atomic*() and atomicOp<*>()

psychocoderHPC · 2022-08-08T10:06:20Z

For an unknown reason, the OpenACC test shows access to invalid memory and HIP requires over 60 minutes to compile the atomic test.

psychocoderHPC · 2022-08-09T14:01:12Z

test/unit/atomic/src/AtomicFunctors.hpp

+        using Op = alpaka::AtomicAdd;
+
+        template<typename... TArgs>
+        static ALPAKA_FN_ACC auto atomic(TArgs&&... args)


@jkelling found out that this variadic template usage is the root of the nvhpc error (invalid memory access)

psychocoderHPC · 2023-09-08T07:33:08Z

The fix for atomics is already merged with #1773.
Still open is to extent the test and check if we still run into the issue that compiling tests takes ages.

Atomic decrement implemented ```C++ ((old >= value) ? 0 : static_cast<T>(old - 1)) ``` instead of ```C++ (old == static_cast<T>(0) || old > value) ? value : static_cast<T>(old - static_cast<T>(1)) ```

psychocoderHPC · 2025-11-27T12:50:42Z

Note the reason why this PR was never merged is that old HIP compilers running into stack issues and the compile time was increasing to an unacceptable time.

- add define `ALPAKA_ARCH_AMD` as replacement for `ALPAKA_COMP_HIP` - set for backwards compatibility `ALPAKA_COMP_HIP` to `ALPAKA_ARCH_AMD` - `ALPAKA_ARCH_AMD` behaves like `ALPAKA_ARCH_PTX` and provides the AMD architecture as version number - move pre-prozessor version number generators to own file - add more/better tests for the version macros

fix alpaka-group#1769 - test all hierarchies which can be used for atomics - extent test cases to test for equal, smaller, larger and zero as left side operand - test calling the atomic interface `atomic*()` and `atomicOp<*>()`

Clang for HIP as problems if we have all atomic tests within one kernel and throws the compiler error: `error: stack size limit exceeded (155632) in _ZN6alpaka16uniform_cuda_hip6de`, therefore we split the tests into multiple kernel to workaround the issue.

psychocoderHPC · 2025-11-27T13:02:12Z

I rebased the PR against the latest dev, including the fix in #2582

Moving over the never merged atomic test from alpaka mainline alpaka-group/alpaka#1772

psychocoderHPC · 2025-11-28T09:37:23Z

I refactored the test gain and hope that HIP is not running into the wall time anymore.
Each operation is now performed within its own kernel, which should simplify the work for the compiler.

Moving over the never merged atomic test from alpaka mainline alpaka-group/alpaka#1772

Change the test structore that each atomic operation is tested within its own kernel to workaround compiler issues with HIP. HIP 6.0 - 6.2 running in the CI into walltime limits because the compile time explodes due to the test.

* fix `atomicDec()` and test all atomic operations Moving over the never merged atomic test from alpaka mainline alpaka-group/alpaka#1772 * apply review comments

psychocoderHPC added Type:Bug Type:Testing Backend:CUDA labels Aug 3, 2022

psychocoderHPC force-pushed the fix-atomics branch 7 times, most recently from a5cb324 to 5e233b9 Compare August 5, 2022 14:49

psychocoderHPC marked this pull request as draft August 5, 2022 14:59

psychocoderHPC force-pushed the fix-atomics branch 8 times, most recently from d95dbb9 to 3e773d2 Compare August 8, 2022 08:53

psychocoderHPC mentioned this pull request Aug 9, 2022

fix clang CUDA atomics #1773

Merged

psychocoderHPC commented Aug 9, 2022

View reviewed changes

psychocoderHPC changed the title ~~fix clang CUDA atomics and refactor atomic tests~~ CIrefactor atomic tests Sep 8, 2023

psychocoderHPC changed the title ~~CIrefactor atomic tests~~ CI: refactor and extend atomic tests Sep 8, 2023

psychocoderHPC force-pushed the fix-atomics branch from 8f0e3eb to 3408a7c Compare January 22, 2024 17:05

fix atomicDec() for CPU

d0add5a

Atomic decrement implemented ```C++ ((old >= value) ? 0 : static_cast<T>(old - 1)) ``` instead of ```C++ (old == static_cast<T>(0) || old > value) ? value : static_cast<T>(old - static_cast<T>(1)) ```

psychocoderHPC mentioned this pull request Nov 27, 2025

fix atomicDec() for CPU #2582

Merged

psychocoderHPC added 3 commits November 27, 2025 13:58

tests: rewrite atomic tests

2e83db1

fix alpaka-group#1769 - test all hierarchies which can be used for atomics - extent test cases to test for equal, smaller, larger and zero as left side operand - test calling the atomic interface `atomic*()` and `atomicOp<*>()`

test woraround stack issue

1e64175

psychocoderHPC force-pushed the fix-atomics branch from 3408a7c to c34d7ec Compare November 27, 2025 12:59

psychocoderHPC requested review from a team and SimeonEhrig and removed request for SimeonEhrig November 27, 2025 13:01

psychocoderHPC added this to the 2.1.0 milestone Nov 27, 2025

psychocoderHPC marked this pull request as ready for review November 27, 2025 13:02

refactor to hope that the compiletime goes down

f52f96d

psychocoderHPC force-pushed the fix-atomics branch from c34d7ec to f52f96d Compare November 27, 2025 13:17

psychocoderHPC added a commit to psychocoderHPC/alpaka3 that referenced this pull request Nov 27, 2025

fix atomicDec() and test all atomic operations

ac1f078

Moving over the never merged atomic test from alpaka mainline alpaka-group/alpaka#1772

psychocoderHPC added a commit to psychocoderHPC/alpaka3 that referenced this pull request Nov 27, 2025

fix atomicDec() and test all atomic operations

094cce5

Moving over the never merged atomic test from alpaka mainline alpaka-group/alpaka#1772

psychocoderHPC added a commit to psychocoderHPC/alpaka3 that referenced this pull request Nov 27, 2025

fix atomicDec() and test all atomic operations

4935c34

Moving over the never merged atomic test from alpaka mainline alpaka-group/alpaka#1772

psychocoderHPC mentioned this pull request Nov 27, 2025

fix atomicDec() and test all atomic operations alpaka-group/alpaka3#362

Merged

1 task

psychocoderHPC added a commit to psychocoderHPC/alpaka3 that referenced this pull request Nov 27, 2025

fix atomicDec() and test all atomic operations

f0af985

Moving over the never merged atomic test from alpaka mainline alpaka-group/alpaka#1772

psychocoderHPC added a commit to psychocoderHPC/alpaka3 that referenced this pull request Nov 27, 2025

fix atomicDec() and test all atomic operations

c29976f

Moving over the never merged atomic test from alpaka mainline alpaka-group/alpaka#1772

psychocoderHPC added a commit to psychocoderHPC/alpaka3 that referenced this pull request Nov 28, 2025

fix atomicDec() and test all atomic operations

fb04225

Moving over the never merged atomic test from alpaka mainline alpaka-group/alpaka#1772

psychocoderHPC force-pushed the fix-atomics branch 2 times, most recently from 8158db5 to 194411c Compare November 28, 2025 09:34

psychocoderHPC added a commit to psychocoderHPC/alpaka3 that referenced this pull request Nov 28, 2025

fix atomicDec() and test all atomic operations

e66dece

Moving over the never merged atomic test from alpaka mainline alpaka-group/alpaka#1772

psychocoderHPC force-pushed the fix-atomics branch 2 times, most recently from 18a7522 to da14a7f Compare November 28, 2025 10:21

refactor tests to fix HIP compile issues

db6fbe8

Change the test structore that each atomic operation is tested within its own kernel to workaround compiler issues with HIP. HIP 6.0 - 6.2 running in the CI into walltime limits because the compile time explodes due to the test.

psychocoderHPC force-pushed the fix-atomics branch from da14a7f to db6fbe8 Compare November 28, 2025 10:22

psychocoderHPC modified the milestones: 2.1.0, 2.2.0 Dec 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CI: refactor and extend atomic tests #1772

CI: refactor and extend atomic tests #1772

Uh oh!

psychocoderHPC commented Aug 3, 2022 •

edited

Loading

Uh oh!

psychocoderHPC commented Aug 8, 2022

Uh oh!

psychocoderHPC Aug 9, 2022

Uh oh!

psychocoderHPC commented Sep 8, 2023

Uh oh!

psychocoderHPC commented Nov 27, 2025

Uh oh!

psychocoderHPC commented Nov 27, 2025

Uh oh!

psychocoderHPC commented Nov 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

CI: refactor and extend atomic tests #1772

Are you sure you want to change the base?

CI: refactor and extend atomic tests #1772

Uh oh!

Conversation

psychocoderHPC commented Aug 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

psychocoderHPC commented Aug 8, 2022

Uh oh!

psychocoderHPC Aug 9, 2022

Choose a reason for hiding this comment

Uh oh!

psychocoderHPC commented Sep 8, 2023

Uh oh!

psychocoderHPC commented Nov 27, 2025

Uh oh!

psychocoderHPC commented Nov 27, 2025

Uh oh!

psychocoderHPC commented Nov 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

psychocoderHPC commented Aug 3, 2022 •

edited

Loading