Cherry-pick feature commits into 1.0.0 #2178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add missing ALPAKA_UNREACHABLE * Silence more warnings Co-authored-by: Bernhard Manfred Gruber <[email protected]>
Move template `TPlatform` as the last template. There is no need to provide the platform template signature if we pass the platform as an instance.
Fixes the following warning:
```
/builds/hzdr/crp/alpaka/test/unit/math/src/Defines.hpp:52:35: error: left operand of comma operator has no effect [-Werror=unused-value]
52 | for(size_t i = 0; i < argsItem.arity_nr; ++i)
| ~~~~~~~~~^~~~~~~~~~
```
* Workaround clang not recognizing ternay expression * Implement atomicInc/atomicDec via omp critical Fixes: alpaka-group#2170
clang warns that the names of the captures shadow the outside variables.
E.g.:
QueueUniformCudaHipRt.hpp:215:57: error: declaration shadows a local variable [-Werror,-Wshadow-uncaptured-local]
215 | auto f = queue.m_callbackThread.submit([data = std::move(data)] { data->t(); });
| ^
They fail with: ptxas /tmp/randomStrategies-sm_61-768a17.s, line 14415; fatal : Parsing error near '.': syntax error ptxas fatal : Ptx assembly aborted due to errors clang++: error: ptxas command failed with exit code 255 (use -v to see invocation)
CUDA/HIP/SYCL is marked as untested for now.
bernhardmgruber
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks the feature commits into the
1.0.0-rc1branch that have been added over the past week and need to go into the 1.0.0 release. After this is merged the 1.0.0 release is feature-complete, only the changelog and maybe #2177 must be added before the release is tagged.