Skip to content

backport: network status rpc method, urls and frontend deps#236

Merged
storopoli merged 1 commit into
internal-dashboardfrom
backport-to-internal
Jun 3, 2026
Merged

backport: network status rpc method, urls and frontend deps#236
storopoli merged 1 commit into
internal-dashboardfrom
backport-to-internal

Conversation

@krsnapaudel

Copy link
Copy Markdown
Collaborator

Description

Backport of #234 to `internal-dashboard.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor
  • Dependency update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@krsnapaudel krsnapaudel requested a review from purusang as a code owner June 1, 2026 20:28
@krsnapaudel krsnapaudel changed the base branch from main to internal-dashboard June 1, 2026 20:28
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review


P2 Badge Wrap the lazy balances page in a Suspense boundary

When a user navigates to /balances, this renders the React.lazy Balances component without any active Suspense ancestor; the only Suspense in this component is inside the network-page branch, which is not rendered for this path. The first visit to the new page can therefore suspend while loading the chunk and React will throw instead of displaying the balances page, so this route should be rendered under a Suspense fallback.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@krsnapaudel krsnapaudel requested a review from storopoli June 1, 2026 20:33
Comment thread backend/example-config.toml Outdated
* fix(network): update rpc method and urls

* fix(frontend): align react-dom with react
@krsnapaudel krsnapaudel force-pushed the backport-to-internal branch from dbcc34f to b314d91 Compare June 1, 2026 21:24

@storopoli storopoli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b314d91

@storopoli storopoli merged commit df4e421 into internal-dashboard Jun 3, 2026
11 checks passed
voidash added a commit that referenced this pull request Jun 5, 2026
Resolve conflicts after #236 (RPC method rename + testnet-v2 migration):
- status.rs: keep RPC-backed health implementation (superset of #236's
  strata_getChainStatus migration; richer OL/EVM parsing + tests)
- example-config.toml: adopt #236 testnet-v2 staging URLs; add eth_rpc_url
  aligned to the same staging endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants