chore: delete legacy functional-tests directory (STR-2085) by voidash · Pull Request #1581 · alpenlabs/alpen

voidash · 2026-04-07T12:10:13Z

Summary

Deletes the entire functional-tests/ directory. All tests have been migrated to functional-tests-new/ or their invariants tracked in JIRA/Notion.

What's deleted

tests/btcio/ (6 files), RPCs removed from new binary
tests/crash/ (4 files), migrated in PR feat(test): add crash injection to new strata binary (STR-2092) #1580
tests/dbtool/, already migrated
tests/sync/ (5 files), sync_genesis migrated below, rest purged (RPCs don't exist)
tests/prover/, purged in PR chore(functional-tests): purge legacy prover tests (STR-2092) #1517
tests/el_sync_from_chainstate.py, reth-specific, tracked in STR-2091
All infrastructure: entry.py, envs/, factory/, mixins/, utils/, contracts/, load/

What's added

test_sync_genesis.py verifies chain reaches genesis and tip advances consistently
Fix in strata_seq_fullnode.py: was passing GenesisL1View object instead of int to create_node()

CI changes

Delete .github/workflows/functional.yml (legacy test workflow)
Update test-coverage.yml to remove legacy test job
Update main-eest.yml to use functional-tests-new/
Update dependabot.yml, CODEOWNERS

Test plan

test_sync_genesis passes locally
CI functional-tests-new workflow passes
No stale references to functional-tests/ in CI or docs

github-actions · 2026-04-07T12:44:40Z

Commit: 928cb1e

SP1 Execution Results

program	cycles	success
EVM EE STF	1,318,471	✅
Checkpoint	4,720	✅
Checkpoint New	883,564	✅

codecov · 2026-04-07T12:47:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.47%. Comparing base (6dcc0fb) to head (f9f4bc9).
⚠️ Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (6dcc0fb) and HEAD (f9f4bc9). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (6dcc0fb) HEAD (f9f4bc9)

functional 1 0

@@            Coverage Diff             @@
##             main    #1581      +/-   ##
==========================================
- Coverage   72.35%   62.47%   -9.89%     
==========================================
  Files         687      685       -2     
  Lines       69959    69863      -96     
==========================================
- Hits        50622    43644    -6978     
- Misses      19337    26219    +6882

Flag	Coverage Δ
functional	`?`
unit	`62.47% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 189 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

storopoli

Should we also rename functional-tests-new to simply functional-tests in this PR as well? (I think so)

storopoli

The diff also shows that you've deleted a bunch of functional-tests-new stuff instead of renaming? Is that correct. See screenshot below:

storopoli · 2026-04-08T15:21:48Z

-    commit-message:
-      prefix: "chore(deps)"
-      include: "scope"
+  # Legacy functional-tests/ removed — see functional-tests/


We should keep this, right?

Restored now. The uv block's directory path /functional-tests/ is identical after the rename, so it covers the new framework without any changes.

storopoli · 2026-04-08T15:25:18Z

NOTE to myself. After this PR is merged we need to update the merge queue requirements because of the renaming

voidash · 2026-04-09T11:41:18Z

The diff also shows that you've deleted a bunch of functional-tests-new stuff instead of renaming? Is that correct. See screenshot below:

final tree should be correct. This is because how commits are structured

storopoli

ACK efe9f15

delbonis · 2026-04-09T16:17:49Z

some merge conflicts, will review more thoroughly shortly

storopoli

ACK f81f15c

storopoli · 2026-04-13T14:09:29Z

@delbonis ping, should be ready to merge now.

delbonis · 2026-04-13T18:17:36Z

MERGE CONFLICTS NOOO

storopoli · 2026-04-13T18:18:31Z

I'll fix them and force-merge

Remove the entire functional-tests/ directory. All valuable tests have been migrated to functional-tests-new/ or their invariants tracked in JIRA/Notion. Sync tests: added test_sync_genesis to functional-tests-new. Fullnode lag restart test deferred — fullnode sync not yet implemented in new strata binary (tracked in STR-2091). Also: - Fix bug in strata_seq_fullnode.py: pass genesis_l1.blk.height (int) not GenesisL1View object to create_node() - Delete .github/workflows/functional.yml (legacy test workflow) - Update test-coverage.yml, main-eest.yml, dependabot.yml, CODEOWNERS - Update AGENTS.md, README.md, CONTRIBUTING.md references

Now that the legacy functional-tests/ directory is deleted, drop the -new suffix. Updates all references across CI workflows, justfile, CODEOWNERS, Dockerfile, docs, and .dockerignore.

Test run data directory contains generated TOML files that should not be linted.

…085) - CODEOWNERS: drop fn_*.py and constants.py patterns that match nothing in the new layout. - dependabot.yml: restore the uv ecosystem entry for functional-tests/. It was dropped with the legacy delete, but the path is unchanged after the rename so the new framework still needs Python dependency updates. - functional.yml: filter the coverage-instrumented cargo build to the binaries the new tests actually use, and update the which assertion from strata-client to strata. - FUNCTIONAL_TEST_MIGRATION_STATUS.md: delete the migration tracking doc now that the legacy tree is gone.

The btcio tests (added by PR #1451) were added to main after the rename commit was written. The rebase didn't capture them, leaving orphaned tracked files under functional-tests-new/tests/btcio/.

storopoli · 2026-04-13T18:25:49Z

@voidash heads-up I've rebased this branch and will force merge when CI is all green. 🤞🏻

storopoli · 2026-04-13T19:02:15Z

Ok all green merging this!

storopoli · 2026-04-13T19:05:38Z

NOTE to myself. After this PR is merged we need to update the merge queue requirements because of the renaming

This is done. updated the merge queue requirements. Cc @barakshani

purusang · 2026-04-15T07:28:33Z

@storopoli this is good that it got merged and I like fast development cycles but there was an unresolved concern of mine. I saw you left some reminders for yourself, I guess, you can incorporate it there.

storopoli · 2026-04-15T08:34:18Z

You mean the .dockerignore? I thought that was solved. Ok opened up #1651

storopoli reviewed Apr 7, 2026

View reviewed changes

voidash marked this pull request as ready for review April 8, 2026 12:21

voidash requested review from a team as code owners April 8, 2026 12:21

voidash force-pushed the chore/delete-legacy-functional-tests branch from 0a04001 to f3130d6 Compare April 8, 2026 12:40

storopoli requested changes Apr 8, 2026

View reviewed changes

purusang requested changes Apr 9, 2026

View reviewed changes

Comment thread .dockerignore

storopoli previously approved these changes Apr 9, 2026

View reviewed changes

storopoli enabled auto-merge April 9, 2026 13:15

storopoli requested a review from purusang April 9, 2026 13:15

voidash dismissed storopoli’s stale review via f81f15c April 13, 2026 08:45

voidash force-pushed the chore/delete-legacy-functional-tests branch from efe9f15 to f81f15c Compare April 13, 2026 08:45

prajwolrg previously approved these changes Apr 13, 2026

View reviewed changes

storopoli previously approved these changes Apr 13, 2026

View reviewed changes

delbonis previously approved these changes Apr 13, 2026

View reviewed changes

voidash added 3 commits April 13, 2026 15:19

chore: rename functional-tests-new/ to functional-tests/ (STR-2085)

822f836

Now that the legacy functional-tests/ directory is deleted, drop the -new suffix. Updates all references across CI workflows, justfile, CODEOWNERS, Dockerfile, docs, and .dockerignore.

chore: exclude functional-tests/_dd from taplo formatting

65f75b8

Test run data directory contains generated TOML files that should not be linted.

voidash and others added 2 commits April 13, 2026 15:19

fix: move btcio tests missed during functional-tests rename (STR-2085)

f9f4bc9

The btcio tests (added by PR #1451) were added to main after the rename commit was written. The rebase didn't capture them, leaving orphaned tracked files under functional-tests-new/tests/btcio/.

storopoli dismissed stale reviews from delbonis, prajwolrg, and themself via f9f4bc9 April 13, 2026 18:24

storopoli force-pushed the chore/delete-legacy-functional-tests branch from f81f15c to f9f4bc9 Compare April 13, 2026 18:24

storopoli disabled auto-merge April 13, 2026 19:03

storopoli merged commit 69c9872 into main Apr 13, 2026
31 checks passed

storopoli deleted the chore/delete-legacy-functional-tests branch April 13, 2026 19:03

storopoli mentioned this pull request Apr 15, 2026

chore: add functional-tests to dockerignore #1651

Merged

16 tasks

Conversation

voidash commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What's deleted

What's added

CI changes

Test plan

Uh oh!

github-actions Bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

storopoli left a comment

Choose a reason for hiding this comment

Uh oh!

storopoli left a comment

Choose a reason for hiding this comment

Uh oh!

storopoli Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

voidash Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

storopoli commented Apr 8, 2026

Uh oh!

Uh oh!

voidash commented Apr 9, 2026

Uh oh!

storopoli left a comment

Choose a reason for hiding this comment

Uh oh!

delbonis commented Apr 9, 2026

Uh oh!

storopoli left a comment

Choose a reason for hiding this comment

Uh oh!

storopoli commented Apr 13, 2026

Uh oh!

delbonis commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

storopoli commented Apr 13, 2026

Uh oh!

storopoli commented Apr 13, 2026

Uh oh!

storopoli commented Apr 13, 2026

Uh oh!

Uh oh!

storopoli commented Apr 13, 2026

Uh oh!

purusang commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

storopoli commented Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

voidash commented Apr 7, 2026 •

edited

Loading

github-actions Bot commented Apr 7, 2026 •

edited

Loading

codecov Bot commented Apr 7, 2026 •

edited

Loading

delbonis commented Apr 13, 2026 •

edited

Loading

purusang commented Apr 15, 2026 •

edited

Loading