Skip to content

backport: (STR-1385) Fix broadcaster tracking #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

backport: (STR-1385) Fix broadcaster tracking #826

merged 1 commit into from
May 26, 2025

Conversation

bewakes
Copy link
Contributor

@bewakes bewakes commented May 23, 2025

Release counterpart of #810

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@bewakes bewakes requested review from a team as code owners May 23, 2025 10:31
@bewakes bewakes changed the title (broadcaster): Fix broadcaster state update str-1385: Fix broadcaster tracking May 23, 2025
@bewakes bewakes changed the title str-1385: Fix broadcaster tracking backport: (str-1385) Fix broadcaster tracking May 23, 2025
@bewakes bewakes changed the title backport: (str-1385) Fix broadcaster tracking backport: (STR-1385) Fix broadcaster tracking May 23, 2025
@storopoli
Copy link
Member

Needs rebase and why CI is failing?

@delbonis
Copy link
Contributor

@storopoli Looks like imports and a fn that was renamed breaking things.

delbonis
delbonis previously approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@delbonis delbonis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(approved w/ pending merge conflicts)

@bewakes bewakes force-pushed the str-1385-fix-broadcaster-tracking-releasev2 branch from f7b4e7d to bf970dd Compare May 26, 2025 05:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 26, 2025 •
edited
Loading

Commit: 55ee440

SP1 Execution Results

program cycles success
Bitcoin Blockspace 71,672 ✅
EVM EE STF 277,310 ✅
CL STF 167,016 ✅
Checkpoint 4,252 ✅

@bewakes
(broadcaster): Fix broadcaster state update
f58af1c 
broadcaster: refactor

Increase default poll interval for writer, update writer log

Update logging; use spans

Rename existing Indexed struct to IndexedItem and polished the interface

(broadcaster): Use IndexedITem instead of tuple

(primitives): Rename IndexedItem to Indexed
@bewakes bewakes force-pushed the str-1385-fix-broadcaster-tracking-releasev2 branch from bf970dd to f58af1c Compare May 26, 2025 06:52
@sapinb sapinb merged commit c6905f7 into releases/0.2.0 May 26, 2025
16 checks passed
@sapinb sapinb deleted the str-1385-fix-broadcaster-tracking-releasev2 branch May 26, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delbonis delbonis delbonis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bewakes @storopoli @delbonis @sapinb