Skip to content

refactor(stf): consolidate block validation into compute_asm_transition#11

Merged
prajwolrg merged 2 commits intomainfrom
STR-2619-asm-block-validation
Mar 20, 2026
Merged

refactor(stf): consolidate block validation into compute_asm_transition#11
prajwolrg merged 2 commits intomainfrom
STR-2619-asm-block-validation

Conversation

@prajwolrg
Copy link
Copy Markdown
Collaborator

@prajwolrg prajwolrg commented Mar 19, 2026

Description

Move merkle root validation, witness commitment check, witness root computation, and transaction grouping from callers into the core STF function. This removes the AsmStfInput intermediary so callers pass bitcoin::Block and AuxData directly, ensuring validation happens in one place.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency update
  • Security fix

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@prajwolrg prajwolrg force-pushed the STR-2619-asm-block-validation branch from 304f040 to 5b449a0 Compare March 19, 2026 12:04
@github-actions
Copy link
Copy Markdown

Commit: 101b794
SP1 Execution Results

program cycles success
ASM STF 533,229,433 yes

@prajwolrg prajwolrg self-assigned this Mar 19, 2026
@prajwolrg prajwolrg added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit 8248499 Mar 20, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants