refactor(stf): consolidate block validation into compute_asm_transition#11
Merged
refactor(stf): consolidate block validation into compute_asm_transition#11
Conversation
304f040 to
5b449a0
Compare
|
Commit: 101b794
|
MdTeach
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move merkle root validation, witness commitment check, witness root computation, and transaction grouping from callers into the core STF function. This removes the
AsmStfInputintermediary so callers passbitcoin::BlockandAuxDatadirectly, ensuring validation happens in one place.Type of Change
Notes to Reviewers
Checklist
Related Issues