Skip to content

feat: add SP1 proof generation support to ASM runner#54

Merged
prajwolrg merged 2 commits intomainfrom
STR-2926-sp1-asm-proof
Apr 4, 2026
Merged

feat: add SP1 proof generation support to ASM runner#54
prajwolrg merged 2 commits intomainfrom
STR-2926-sp1-asm-proof

Conversation

@prajwolrg
Copy link
Copy Markdown
Collaborator

@prajwolrg prajwolrg commented Apr 2, 2026

Description

  • Add SP1 proof generation behind a sp1 feature flag in asm-runner, using zkaleido-sp1-host and the SP1 guest ELF binary
  • Update functional tests to support SP1 proof runs by increasing proof wait timeout from 60s to 600s to accommodate real proof generation times

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency update
  • Security fix

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

Commit: cfae5f8
SP1 Execution Results

program cycles success
ASM STF 122,849,241 yes
Moho Recursive 630,278 yes

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
bin/asm-runner/src/bootstrap.rs 42.85% 4 Missing ⚠️
Files with missing lines Coverage Δ
bin/asm-runner/src/bootstrap.rs 91.25% <42.85%> (-4.75%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@prajwolrg prajwolrg force-pushed the STR-2926-sp1-asm-proof branch from 4797381 to b86618d Compare April 2, 2026 15:57
@prajwolrg prajwolrg mentioned this pull request Apr 2, 2026
14 tasks
Copy link
Copy Markdown

@MdTeach MdTeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Just a question:

Comment thread functional-tests/README.md
Copy link
Copy Markdown
Collaborator

@evgenyzdanovich evgenyzdanovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@prajwolrg prajwolrg changed the base branch from STR-2936-decouple-strata-asm-spec-from-params to main April 4, 2026 03:47
@prajwolrg prajwolrg force-pushed the STR-2926-sp1-asm-proof branch from b86618d to 7159ba5 Compare April 4, 2026 03:52
@prajwolrg prajwolrg added this pull request to the merge queue Apr 4, 2026
Merged via the queue into main with commit 54c7bc0 Apr 4, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants