Skip to content

Alpen deps cleanup outta here#60

Merged
prajwolrg merged 4 commits intomainfrom
alpen-cleanup
Apr 7, 2026
Merged

Alpen deps cleanup outta here#60
prajwolrg merged 4 commits intomainfrom
alpen-cleanup

Conversation

@evgenyzdanovich
Copy link
Copy Markdown
Collaborator

Description

~Mostly removing reliance onto alpen repo

P.S. Still some messiness left with regards to strata-bridge transitive deps onto alpen (so strata-bridge requires followup changes after which patch can be removed)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency update
  • Security fix

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

Commit: 1406a5a
SP1 Execution Results

program cycles success
ASM STF 118,483,823 yes
Moho Recursive 11,586,699 yes

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 56.47059% with 111 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/common/src/sorted_vec.rs 56.47% 111 Missing ⚠️
Files with missing lines Coverage Δ
crates/checkpoint-types/src/claim.rs 42.55% <ø> (ø)
crates/manifest-types/src/log.rs 74.24% <ø> (ø)
crates/manifest-types/src/manifest.rs 87.82% <ø> (ø)
...tes/subprotocols/bridge-v1/src/state/assignment.rs 94.58% <ø> (+0.21%) ⬆️
crates/subprotocols/bridge-v1/src/state/deposit.rs 95.45% <ø> (ø)
...rates/subprotocols/bridge-v1/src/state/operator.rs 96.64% <ø> (ø)
crates/common/src/sorted_vec.rs 56.47% <56.47%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@evgenyzdanovich evgenyzdanovich changed the base branch from bin-better-storage to main April 6, 2026 14:35
Copy link
Copy Markdown
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concept ACK

Copies the ssz_proptest! macro into crates/test-utils/ssz
(strata-asm-test-utils-ssz), removing the dependency on alpen's
strata-test-utils-ssz.

This eliminates one more alpen dependency from the workspace.
Copies sorted_vec.rs into strata-asm-common. The only thing ASM used
from strata-primitives was SortedVec (in bridge-v1 subprotocol).
SortedVec has zero strata deps — just std, borsh, thiserror.

strata-primitives is now fully eliminated from the ASM workspace.
@evgenyzdanovich evgenyzdanovich marked this pull request as ready for review April 7, 2026 13:28
@evgenyzdanovich evgenyzdanovich changed the title [DRAFT] Alpen deps cleanup ouuta here Alpen deps cleanup ouuta here Apr 7, 2026
@evgenyzdanovich evgenyzdanovich changed the title Alpen deps cleanup ouuta here Alpen deps cleanup outta here Apr 7, 2026
Copy link
Copy Markdown
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 896893d

Comment thread Cargo.toml
@prajwolrg prajwolrg added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit f26ff90 Apr 7, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants