Skip to content

feat(asm-worker): add retry for fetching l1 block#62

Merged
evgenyzdanovich merged 1 commit intomainfrom
asm-worker-retry-block-fetch
Apr 8, 2026
Merged

feat(asm-worker): add retry for fetching l1 block#62
evgenyzdanovich merged 1 commit intomainfrom
asm-worker-retry-block-fetch

Conversation

@prajwolrg
Copy link
Copy Markdown
Collaborator

@prajwolrg prajwolrg commented Apr 7, 2026

Description

Upstreaming ASM-worker changes from alpenlabs/alpen#1451.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency update
  • Security fix

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Commit: 3a98b2a
SP1 Execution Results

program cycles success
ASM STF 118,483,823 yes
Moho Recursive 11,586,699 yes

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/worker/src/service.rs 62.50% 6 Missing ⚠️
Files with missing lines Coverage Δ
crates/worker/src/service.rs 80.48% <62.50%> (-2.85%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@prajwolrg prajwolrg self-assigned this Apr 8, 2026
Copy link
Copy Markdown
Collaborator

@evgenyzdanovich evgenyzdanovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats neat and good to go as well.

P.S. I wonder if we have some kind of "retries primitive" so it can be used throughout the code (and placed in common) - we keep inventing our-inline-exp-backoff here and there (which is alright-ish, but it can be better)

@evgenyzdanovich evgenyzdanovich added this pull request to the merge queue Apr 8, 2026
Merged via the queue into main with commit b66b342 Apr 8, 2026
21 of 22 checks passed
@prajwolrg
Copy link
Copy Markdown
Collaborator Author

thats neat and good to go as well.

P.S. I wonder if we have some kind of "retries primitive" so it can be used throughout the code (and placed in common) - we keep inventing our-inline-exp-backoff here and there (which is alright-ish, but it can be better)

Yes, please! This is something that should be in a common repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants