Skip to content

chore: break strata-bridge dep cycle#65

Merged
evgenyzdanovich merged 3 commits intomainfrom
break-bridge-cycle
Apr 8, 2026
Merged

chore: break strata-bridge dep cycle#65
evgenyzdanovich merged 3 commits intomainfrom
break-bridge-cycle

Conversation

@evgenyzdanovich
Copy link
Copy Markdown
Collaborator

Description

No longer rely on strata-bridge, as it introduces deps management issues.
Asm repo is a "lower level" lib repo that should depend upon higher level repos.

changes:

  • thin out a minimalistic ZMQ glue from btc-tracker.
  • purge strata-bridge-common and sub with tracing-subscriber
  • remove patch section entirely.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency update
  • Security fix

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Replace the dependency on strata-bridge's btc-tracker and
strata-bridge-common with:
- A minimal block_watcher.rs - ZMQ glue atop bitcoind
- A local init_logging() fn using tracing_subscriber directly.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Commit: 2d67521
SP1 Execution Results

program cycles success
ASM STF 118,483,823 yes
Moho Recursive 11,586,699 yes

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 85.04673% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
bin/asm-runner/src/block_watcher.rs 82.41% 16 Missing ⚠️
Files with missing lines Coverage Δ
bin/asm-runner/src/bootstrap.rs 91.35% <100.00%> (+0.10%) ⬆️
bin/asm-runner/src/main.rs 97.50% <100.00%> (+0.62%) ⬆️
bin/asm-runner/src/block_watcher.rs 82.41% <82.41%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@prajwolrg prajwolrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@evgenyzdanovich evgenyzdanovich added this pull request to the merge queue Apr 8, 2026
Merged via the queue into main with commit 124edbf Apr 8, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants