Skip to content

fix(bridge-v1): correct DRT skip logging and add tx-level info logs#66

Merged
prajwolrg merged 3 commits intomainfrom
STR-2581-fix-drt-error-log
Apr 9, 2026
Merged

fix(bridge-v1): correct DRT skip logging and add tx-level info logs#66
prajwolrg merged 3 commits intomainfrom
STR-2581-fix-drt-error-log

Conversation

@prajwolrg
Copy link
Copy Markdown
Collaborator

@prajwolrg prajwolrg commented Apr 8, 2026

Description

The bridge subprotocol was logging DepositRequest transactions as error! events even though they're expected to be skipped at the parse stage and re-fetched as auxiliary input alongside their Deposit. That made the error log noisy and obscured real failures. This branch fixes that and rebuilds the surrounding logging to actually be useful.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency update
  • Security fix

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@prajwolrg prajwolrg requested a review from MdTeach April 8, 2026 12:02
@prajwolrg prajwolrg changed the title Str 2581 fix drt error log fix(bridge-v1): correct DRT skip logging and add tx-level info logs Apr 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Commit: da2d2b8
SP1 Execution Results

program cycles success
ASM STF 118,483,819 yes
Moho Recursive 11,586,699 yes

@prajwolrg prajwolrg marked this pull request as ready for review April 8, 2026 12:05
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 56.81818% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/txs/bridge-v1/src/parser.rs 40.00% 15 Missing ⚠️
crates/subprotocols/bridge-v1/src/handler.rs 71.42% 4 Missing ⚠️
Files with missing lines Coverage Δ
crates/subprotocols/bridge-v1/src/subprotocol.rs 77.27% <100.00%> (-4.73%) ⬇️
crates/txs/bridge-v1/src/errors.rs 62.50% <ø> (ø)
crates/subprotocols/bridge-v1/src/handler.rs 93.75% <71.42%> (-2.04%) ⬇️
crates/txs/bridge-v1/src/parser.rs 42.30% <40.00%> (-0.55%) ⬇️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@prajwolrg prajwolrg self-assigned this Apr 8, 2026
Copy link
Copy Markdown

@MdTeach MdTeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks.

@prajwolrg prajwolrg added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit a47f5c9 Apr 9, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants