Skip to content

feat: parametrize worker over spec#67

Merged
evgenyzdanovich merged 1 commit intomainfrom
worker-generic-spec
Apr 9, 2026
Merged

feat: parametrize worker over spec#67
evgenyzdanovich merged 1 commit intomainfrom
worker-generic-spec

Conversation

@evgenyzdanovich
Copy link
Copy Markdown
Collaborator

Description

Alpen uses different ASM spec (with or without debug subproto) based on the features.
So worker ideally needs to be parameterized over the spec, otherwise its unusable

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency update
  • Security fix

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Commit: f38ca57
SP1 Execution Results

program cycles success
ASM STF 118,483,823 yes
Moho Recursive 11,586,699 yes

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
bin/asm-runner/src/bootstrap.rs 91.46% <100.00%> (+0.10%) ⬆️
crates/worker/src/builder.rs 92.68% <100.00%> (+1.50%) ⬆️
crates/worker/src/service.rs 80.95% <100.00%> (+0.46%) ⬆️
crates/worker/src/state.rs 72.72% <100.00%> (+0.27%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@evgenyzdanovich evgenyzdanovich added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit 359cb7f Apr 9, 2026
22 checks passed
evgenyzdanovich added a commit to alpenlabs/alpen that referenced this pull request Apr 9, 2026
Resolves remaining compile + test failures against asm's post-#52/#65
layout. Pins temporarily at head of alpenlabs/asm#67 — revert to
`tag = "v0.1.0-rc2"` once that PR merges.
evgenyzdanovich added a commit to alpenlabs/alpen that referenced this pull request Apr 10, 2026
Resolves remaining compile + test failures against asm's post-#52/#65
layout. Pins temporarily at head of alpenlabs/asm#67 — revert to
`tag = "v0.1.0-rc2"` once that PR merges.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants