Skip to content

chore: use zkaleido logging #69

Merged
prajwolrg merged 1 commit intomainfrom
use-zkaleido-logging
Apr 10, 2026
Merged

chore: use zkaleido logging #69
prajwolrg merged 1 commit intomainfrom
use-zkaleido-logging

Conversation

@prajwolrg
Copy link
Copy Markdown
Collaborator

@prajwolrg prajwolrg commented Apr 9, 2026

Description

zkaleido-logging is a separate crate that implements noop logging for ZkVm builds. This PR uses that directly instead of now redefining the logic again.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency update
  • Security fix

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@prajwolrg prajwolrg changed the title feat: use zkaleido logging chore: use zkaleido logging Apr 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Commit: da0a469
SP1 Execution Results

program cycles success
ASM STF 118,483,823 yes
Moho Recursive 11,586,718 yes

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@prajwolrg prajwolrg self-assigned this Apr 9, 2026
Copy link
Copy Markdown
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5e4ab68

@prajwolrg prajwolrg added this pull request to the merge queue Apr 10, 2026
Merged via the queue into main with commit c0e341e Apr 10, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants