Skip to content

feat: add ASM STF guest code and prover perf tooling#9

Merged
prajwolrg merged 8 commits intomainfrom
STR-2411-asm-guest-code
Mar 19, 2026
Merged

feat: add ASM STF guest code and prover perf tooling#9
prajwolrg merged 8 commits intomainfrom
STR-2411-asm-guest-code

Conversation

@prajwolrg
Copy link
Copy Markdown
Collaborator

@prajwolrg prajwolrg commented Mar 18, 2026

Description

  • Add SP1 guest program for the ASM STF proof (guest-builder/sp1/guest-asm)
  • Refactor proof-impl to extract test utilities into a dedicated test_utils module
  • Add prover-perf binary for benchmarking and profiling guest code execution
  • Add CI workflow to run prover-perf in mock mode and just recipes for local profiling

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency update
  • Security fix

Notes to Reviewers

AI was used to copy the existing code pattern from alpen.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@prajwolrg prajwolrg changed the title Str 2411 asm guest code feat: add ASM STF guest code and prover performance tooling Mar 18, 2026
@prajwolrg prajwolrg changed the title feat: add ASM STF guest code and prover performance tooling feat: add ASM STF guest code and prover perf tooling Mar 18, 2026
@prajwolrg prajwolrg marked this pull request as ready for review March 18, 2026 04:09
@prajwolrg prajwolrg force-pushed the STR-2411-asm-guest-code branch 2 times, most recently from 22ce406 to 922f1c2 Compare March 18, 2026 05:41
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026

Commit: cf972a4
SP1 Execution Results

program cycles success
ASM STF 533,229,620 yes

@prajwolrg prajwolrg force-pushed the STR-2411-asm-guest-code branch from fd99024 to c5c170c Compare March 18, 2026 06:09
@prajwolrg prajwolrg self-assigned this Mar 18, 2026
@irnb irnb self-requested a review March 18, 2026 09:24
MdTeach

This comment was marked as spam.

Copy link
Copy Markdown

@MdTeach MdTeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good.
The cycle count appears higher than anticipated.

Comment thread bin/prover-perf/src/format.rs
Comment thread guest-builder/sp1/guest-asm/src/main.rs
Copy link
Copy Markdown

@delbonis delbonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some organizational comments.

Comment thread guest-builder/sp1/guest-asm/src/main.rs
Comment thread guest-builder/sp1/guest-asm/src/main.rs
Comment thread crates/proof/statements/src/test_utils.rs
Comment thread bin/prover-perf/src/github.rs
@prajwolrg prajwolrg requested a review from delbonis March 18, 2026 15:59
Copy link
Copy Markdown
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1252fbe

@storopoli storopoli enabled auto-merge March 18, 2026 17:36
@prajwolrg prajwolrg disabled auto-merge March 19, 2026 02:03
@prajwolrg prajwolrg enabled auto-merge March 19, 2026 02:07
@prajwolrg prajwolrg added this pull request to the merge queue Mar 19, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2026
@prajwolrg prajwolrg force-pushed the STR-2411-asm-guest-code branch from 1252fbe to 07f2e5b Compare March 19, 2026 02:41
@prajwolrg prajwolrg added this pull request to the merge queue Mar 19, 2026
Merged via the queue into main with commit 5970a7b Mar 19, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants