feat: add ASM STF guest code and prover perf tooling#9
Merged
Conversation
14 tasks
22ce406 to
922f1c2
Compare
|
Commit: cf972a4
|
fd99024 to
c5c170c
Compare
MdTeach
reviewed
Mar 18, 2026
MdTeach
left a comment
There was a problem hiding this comment.
Overall, this looks good.
The cycle count appears higher than anticipated.
delbonis
requested changes
Mar 18, 2026
delbonis
left a comment
There was a problem hiding this comment.
Looks good, just some organizational comments.
MdTeach
approved these changes
Mar 18, 2026
delbonis
approved these changes
Mar 18, 2026
storopoli
approved these changes
Mar 18, 2026
irnb
approved these changes
Mar 19, 2026
1252fbe to
07f2e5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
guest-builder/sp1/guest-asm)proof-implto extract test utilities into a dedicatedtest_utilsmoduleprover-perfbinary for benchmarking and profiling guest code executionType of Change
Notes to Reviewers
AI was used to copy the existing code pattern from
alpen.Checklist
Related Issues