[Zenith] L-3 Missing assertions for equal points in add_montgomery#63
Open
manishbista28 wants to merge 1 commit intomainfrom
Open
[Zenith] L-3 Missing assertions for equal points in add_montgomery#63manishbista28 wants to merge 1 commit intomainfrom
manishbista28 wants to merge 1 commit intomainfrom
Conversation
| )); | ||
| } | ||
|
|
||
| // given two bases M and N which were both known in compile time, |
Contributor
There was a problem hiding this comment.
For this case, can we assume that M and N have no efficiently-computable discrete logarithm relation?
Contributor
Author
There was a problem hiding this comment.
M and N are public input commitment part of verification keys, so I assume M and N do not have efficiently-computable discrete log relation.
If they did, you'd be able to supply scalars a or b such that [a]M = [b]N.
Without [a]M = [b]N, there won't be a case where input to add_montgomery(circuit, [a]M, [b]N) will have same value of operands. Thus the equal points in add_montgomery will not hit.
Contributor
There was a problem hiding this comment.
Let's double-check the claim that as part of the verification keys, they cannot have a known discrete logarithm relation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20