Skip to content

refactor: combine evaluator table-transfer into single action#159

Merged
Zk2u merged 3 commits intomainfrom
fix/154-combine-table-transfer-actions
Apr 9, 2026
Merged

refactor: combine evaluator table-transfer into single action#159
Zk2u merged 3 commits intomainfrom
fix/154-combine-table-transfer-actions

Conversation

@sapinb
Copy link
Copy Markdown
Collaborator

@sapinb sapinb commented Apr 7, 2026

Description

Fold SendTableTransferRequest into ReceiveGarblingTable so the evaluator registers its bulk-transfer expectation before sending the request to the garbler, eliminating a race where the request could arrive before local readiness was installed. Remove the now-dead SendTableTransferRequest action, TableTransferRequestAcked result, and all associated plumbing.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency update
  • Security fix

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

closes #154

Fold SendTableTransferRequest into ReceiveGarblingTable so the evaluator
registers its bulk-transfer expectation before sending the request to the
garbler, eliminating a race where the request could arrive before local
readiness was installed. Remove the now-dead SendTableTransferRequest
action, TableTransferRequestAcked result, and all associated plumbing.
@sapinb sapinb force-pushed the fix/154-combine-table-transfer-actions branch from c5d35ed to 33a170c Compare April 7, 2026 19:38
@sapinb sapinb requested a review from Zk2u April 7, 2026 20:37
@sapinb sapinb marked this pull request as ready for review April 7, 2026 20:38
@Zk2u Zk2u merged commit d7a1f5a into main Apr 9, 2026
14 checks passed
@Zk2u Zk2u deleted the fix/154-combine-table-transfer-actions branch April 9, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

evaluator: combine table-transfer readiness and request into a single ReceiveGarblingTable action

2 participants