Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two independent reliability bugs in the scheduler/executor layer:
PendingCircuitJobs and requeue them on assignment/report/worker failuresm-executormain-loop receives cancel-safe so completed jobs cannot be lost when anotherselect!branch winsWhat changed
Garbling coordinator recovery
PendingCircuitJobis clonable so coordinator-owned recovery bookkeeping stays explicitsm-executor cancel safety
sm-executorno longer recreatesrecv()futures insidemonoio::select!every loop iterationkanaldirect-handoff cancellation hole where a completion can be dropped if a waitingrecv()future is canceled before being polled to completionTests
Added/updated tests for:
kanalwaiting-receive drop loses direct-handoff messageValidation
Passed:
cargo test -p mosaic-sm-executorcargo clippy -p mosaic-sm-executor --tests -- -D warningscargo test -p mosaic-job-schedulercargo clippy -p mosaic-job-scheduler --tests -- -D warningscargo test -p mosaic-job-apicargo fmt --check --alljust -f .justfile cigot through formatting, clippy, docs, and the scheduler/executor portions cleanly, but timed out in unrelated long-runningmosaic-storage-fdbtests in this environment.Notes
I also updated issue #156 to clarify that the rare
GeneratingPolynomialCommitmentswedge is tracked separately in #166 and is not part of the coordinator worker-loss bug.