Skip to content

chore: rename Docker test mode environment variable#171

Open
AaronFeickert wants to merge 1 commit intomainfrom
rename-test-env
Open

chore: rename Docker test mode environment variable#171
AaronFeickert wants to merge 1 commit intomainfrom
rename-test-env

Conversation

@AaronFeickert
Copy link
Copy Markdown
Collaborator

Description

It's possible to run Mosaic in an unsafe test mode, which uses lower cut-and-choose parameters to speed up testing. However, this mode is EXTREMELY UNSAFE to use in production. Recent work in #170 controls which mode is built and run in Docker via an environment variable MOSAIC_REDUCED_CIRCUITS.

This PR renames the compiled binary and environment variable to sound scary and help mitigate unintentional production misuse.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency update
  • Security fix

Notes to Reviewers

This partially addresses #148, which suggests renaming the feature flag that is used under the hood. That renaming is deferred to later.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Partially addresses #148.

@AaronFeickert
Copy link
Copy Markdown
Collaborator Author

@Zk2u @sapinb looks like two new vulnerabilities flagged by CI we get to deal with. Both are in rustls-webpki, used by quinn.

@Zk2u Zk2u enabled auto-merge (squash) April 18, 2026 19:55
@Zk2u Zk2u added this pull request to the merge queue Apr 20, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 20, 2026
@Zk2u Zk2u added this pull request to the merge queue Apr 20, 2026
@Zk2u Zk2u removed this pull request from the merge queue due to a manual request Apr 20, 2026
@Zk2u Zk2u added this pull request to the merge queue Apr 20, 2026
@Zk2u Zk2u removed this pull request from the merge queue due to a manual request Apr 20, 2026
@Zk2u Zk2u force-pushed the rename-test-env branch from 3cbd7dd to 4ee77b8 Compare April 20, 2026 19:01
@Zk2u Zk2u enabled auto-merge April 20, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants