Conversation
8603990 to
16f2c4c
Compare
16f2c4c to
ea67994
Compare
Collaborator
|
We should really be pushing for reviews and not immediate merges. |
14 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements scaffolding and most of the implementation for the NetService. It's mostly broken into two halves:
QUIC uses TLS which is kinda ugly around our usecases, so this uses a custom cert verifier and uses ed25519 TLS keys. This means we only have to keep 32 byte public keys for each peer's identity, rather than full PEM certs and whatever that are manky.
Mosaic has a isolated thread that runs the
net-svc. This uses a single threaded tokio runtime that doesn't leak on the public API.net-svcexposes a public low-level API that allows callers from other threads obtain streams with a given PeerId. There are two stream types, protocol streams and bulk transfer streams. They use the same underlying stream system, but bulk transfer streams have a identifier, and the API to receive incoming streams works differently. This is so garbled table transfers can be received in jobs, and incoming protocol messages can be received by the SMScheduler.net-svcrelies onnet-wirefor the low level wire types.net-svcis mostly built out in this PR with integration tests et al.The next PR will build out the typed layer,
net-typesandnet-client, the latter which will be directly used by Jobs and the SMScheduler for comms.net-clientadds our application specific protocol into the network layer, for example sending protocol messages with priority 0, protocol msg acks with prio 1, and garbling table transfers with prio -1.Type of Change
Notes to Reviewers
Checklist
Related Issues